feat: Introduce markdown renderer #480
Conversation
| [MARKS.BOLD]: (text: any) => `**${text}**`, | ||
| [MARKS.ITALIC]: (text: any) => `*${text}*`, | ||
| [MARKS.UNDERLINE]: (text: any) => `~~${text}~~`, | ||
| [MARKS.CODE]: (text: any) => `\`${text}\``, |
There was a problem hiding this comment.
Does markdown support superscript and subscript?
There was a problem hiding this comment.
https://www.w3schools.io/file/markdown-super-sub-script/
Looks like it's just the html tags sub & sup
There was a problem hiding this comment.
Yes, it indeed supports sub and sup but by using the HTML tags.
I'm not sure if we should try to address this here or leave it to users since it's up to the users if they want to support HTML tags
There was a problem hiding this comment.
What happens with Tables?
| }, | ||
| [BLOCKS.QUOTE]: (node: any, next: any) => `> ${next(node.content)}\n`, | ||
| [BLOCKS.HR]: () => '\n---\n', | ||
| [BLOCKS.EMBEDDED_ENTRY]: () => '', // You can customize embedded entries if needed |
There was a problem hiding this comment.
What happens INLINES.EMBEDDED_ENTRY, INLINES.ENTRY_HYPERLINK, INLINES.ASSET_HYPERLINK?
I wonder would it be useful here to have some placeholder text for rendering these?
Something like <-- inline entry: abc123 --> what do you think?
| "access": "public" | ||
| }, | ||
| "scripts": { | ||
| "build": "tsc --module commonjs && rollup -c rollup.config.js", |
There was a problem hiding this comment.
Not for now but we should really migrate all the builds in this repo to SWC
| ...options.renderMark, | ||
| }, | ||
| renderNode: { | ||
| [BLOCKS.PARAGRAPH]: (node: any, next: any) => `${next(node.content)}\n\n`, |
There was a problem hiding this comment.
Is there a type you can use here instead of any for node and next?
Markdown is one of the most ubiquitous formats to share content, many people rely on it to power their blogs and other tools, with this PR we introduce an official markdown renderer