build: use rollup bundler #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikaan
force-pushed
the
fix/EXT-2116-warning
branch
from
e687659
to
7ab3e89
Compare
davidfateh
reviewed
Aug 31, 2020
.nvmrc
Outdated
| v13.8.0 |
There was a problem hiding this comment.
Why not use a non-dev version of node?
davidfateh
changed the title
jelz
reviewed
Sep 3, 2020
.nvmrc
Outdated
| v13.8.0 |
jelz
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
After getting this contentful/create-contentful-app#15 we have realized the reason for getting that warning is due to how Parcel works internally.
Given that Parcel doesn't provide clear guidance about how to deal with the problem, this PR migrates to another build tool.
Other considered options
esbuildConfiguring esbuild was super easy, incredibly quick and the bundle is eventually smaller. The problem with that is that it is considered an "existence proof", so I wasn't sure to which extent it could be trusted;
Tested cases
To make sure this change is not breaking I have replicated locally the cases we expect to have:
This what bundlers will do and it's been replicated by npm linking the package (this is what
moduleinpackage.jsonis for)<script>For this I wanted to replicate the behavior of importing the package from
unpkg(as we do in the ready-made extensions). According to the documentation, links to libraries will point to whatever is the target ofmain. Hence, in order to test this, I have run a local server which was serving the main file and it was working.Remarks
esbuildexperience over this, but it's a risk which I am not sure we want to take;