Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Variants (Entry, VariantGroup & Type support) & package version bump #108

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

abhishek305
Copy link
Contributor

workerB

Changes:

  • Package version bump: v2.0.1 --> v2.0.2
  • Variant Entry type support.
  • VariantGroup addition to support group-level operations.
  • Entry-level handlers to create/fetch/update variant.

Amitkanswal and others added 2 commits February 12, 2024 15:01
feat:varaint support commit

14 commit

13 commit

12 commit

11 commit

10 commit

9 commit

8 commit

7 commit

6 commit

5 commit

4 commit

3 commit

2 commit

first commit

fix: type for variant instance

fix: type for variant instance & package version
@abhishek305 abhishek305 requested a review from a team as a code owner April 29, 2024 14:04
@abhishek305 abhishek305 changed the title Feat: Variants (Entry, VariantGroup & Type support) & package version bump #107 Feat: Variants (Entry, VariantGroup & Type support) & package version bump Apr 29, 2024
* @return {external:Promise}
*/

fetchVariant(variant_uid: string) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getVariant

* @example appSDK.stack.VariantGroup("variant_group_uid").getVariantsByGroup();
* @return {external:Promise}
*/
getVariantsByGroup() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getVariants

optionParams.query = query;
const options = { params: optionParams, action: 'getVariantGroups' };
return this._connection.sendToParent('stackQuery', options).then(onData).catch(onError);
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getVariantInfo

* @example appSDK.stack.VariantGroup("variant_group_uid").createVariant(variant_payload);
* @return {external:Promise}
*/
createVariant(payload: GenericObjectType) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not have it now.

* @example appSDK.stack.VariantGroup("variant_group_uid").deleteVariant("variant_uid");
* @return {external:Promise}
*/
deleteVariant(variant_uid: string) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not expose it now

@abhishek305 abhishek305 changed the base branch from develop to feature/entry-field-support-in-rte May 2, 2024 12:03
@abhishek305 abhishek305 changed the base branch from feature/entry-field-support-in-rte to develop May 2, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants