-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Variants (Entry, VariantGroup & Type support) & package version bump #108
base: develop
Are you sure you want to change the base?
Conversation
feat: add support for GCP regions
feat:varaint support commit 14 commit 13 commit 12 commit 11 commit 10 commit 9 commit 8 commit 7 commit 6 commit 5 commit 4 commit 3 commit 2 commit first commit fix: type for variant instance fix: type for variant instance & package version
src/stack/api/content-type/entry.ts
Outdated
* @return {external:Promise} | ||
*/ | ||
|
||
fetchVariant(variant_uid: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getVariant
* @example appSDK.stack.VariantGroup("variant_group_uid").getVariantsByGroup(); | ||
* @return {external:Promise} | ||
*/ | ||
getVariantsByGroup() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getVariants
optionParams.query = query; | ||
const options = { params: optionParams, action: 'getVariantGroups' }; | ||
return this._connection.sendToParent('stackQuery', options).then(onData).catch(onError); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getVariantInfo
* @example appSDK.stack.VariantGroup("variant_group_uid").createVariant(variant_payload); | ||
* @return {external:Promise} | ||
*/ | ||
createVariant(payload: GenericObjectType) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not have it now.
* @example appSDK.stack.VariantGroup("variant_group_uid").deleteVariant("variant_uid"); | ||
* @return {external:Promise} | ||
*/ | ||
deleteVariant(variant_uid: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not expose it now
Changes: