Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/entry field support in rte #95

Merged
merged 11 commits into from
May 13, 2024
Merged

Feature/entry field support in rte #95

merged 11 commits into from
May 13, 2024

Conversation

KANE-99
Copy link
Contributor

@KANE-99 KANE-99 commented Sep 15, 2023

This will enable two things:

  1. RTELocation will have access to latest entry data.
  2. Apps can now pass hoveringToolbarOptions in which they can set autoWidth property, So that app can decide on the icon width. (required for Icons like AI Assistant). This will not affect other plugins icon on the hovering toolbar, we are just allowing a particular app to have width according to its icon size.

@KANE-99 KANE-99 requested a review from a team as a code owner September 15, 2023 05:41
Kaushty
Kaushty reviewed Sep 15, 2023
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
@abhishek305 abhishek305 changed the base branch from main to develop May 13, 2024 10:26
@abhishek305 abhishek305 changed the base branch from develop to main May 13, 2024 10:26
@Nilesh-y Nilesh-y changed the base branch from main to develop May 13, 2024 10:29
abhishek305
abhishek305 requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@abhishek305 abhishek305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change for type rest looks good !!

src/RTE/types.tsx Outdated Show resolved Hide resolved
@Nilesh-y Nilesh-y merged commit d19a827 into develop May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaushty Kaushty Kaushty left review comments

@Nilesh-y Nilesh-y Nilesh-y left review comments

@abhishek305 abhishek305 abhishek305 approved these changes

@surajcontentstack surajcontentstack surajcontentstack left review comments

@Deepak-Kharah Deepak-Kharah Awaiting requested review from Deepak-Kharah

@rijil-tr rijil-tr Awaiting requested review from rijil-tr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KANE-99 @abhishek305 @Kaushty @surajcontentstack @Nilesh-y @Amitkanswal