Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added changes for seq_id #29

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Conversation

vkalta
Copy link

@vkalta vkalta commented Feb 8, 2024

This PR is a enhancement task with respect to the previous sync API implementation by replacing sync token with seq id.

@vkalta vkalta requested a review from a team as a code owner February 8, 2024 10:06
Copy link
Contributor

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkalta, https://github.com/contentstack/contentstack-ios/blob/a2f87854f0c0a2232d653b39a52f5126a70e6ea1/ContentstackInternal/BSONObjectIdGenerator.m

seq_id generation using bason lib should be inside the persistence sdk not here. this is part of persistence

@vkalta
Copy link
Author

vkalta commented Feb 13, 2024

@vkalta, https://github.com/contentstack/contentstack-ios/blob/a2f87854f0c0a2232d653b39a52f5126a70e6ea1/ContentstackInternal/BSONObjectIdGenerator.m

seq_id generation using bason lib should be inside the persistence sdk not here. this is part of persistence

By the design currently the seq id, sync token and pagination is currently being updated inside the contentstack-ios project. This is why it was deemed to be added here and not in persistence package. Please let me know your thoughts on it.

Thanks


@param completionBlock called synchronization is done.
*/
- (void)syncSeqIdInit:(void (^)(SyncStack * BUILT_NULLABLE_P syncStack, NSError * BUILT_NULLABLE_P error))completionBlock;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function should be named initSeqSync or initialSequenceSync.

Reasoning: Including "id" in the function name may cause confusion for developers as it doesn't serve any purpose in this context. This function doesn't require any input from the developer.

@vkalta

Copy link
Contributor

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

thanks @vkalta

@ishaileshmishra
Copy link
Contributor

@vkalta , approved but before merging the PR make sure to add below changes :

  • Update the seqIdSync to suggested name in the comment
  • Checks are failing , please check with @aravindbuilt

thank you !

@netrajpatel netrajpatel changed the base branch from next to development September 24, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants