Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: single line line break and unnecessary psuedo editable due to nbsp #160

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: single line line break and unnecessary psuedo editable due to nbsp #160

merged 1 commit into from
Jul 8, 2024

Conversation

faraazb
Copy link
Contributor

@faraazb faraazb commented Jul 8, 2024 •
edited
Loading

Fixes VE-2182

  1. Non-breaking space inserted on editing in content editable leads to unnecessary psuedo editable elements being inserted. Nbsp is now normalized to a standard whitespace.
  2. Psuedo editable element was not being observed so new lines did not trigger an overlay update. The observer now observes and unobserves the psuedo editable correctly.
  3. Enter is now disallowed for single line field type to match the standard text input

@faraazb faraazb requested a review from a team as a code owner July 8, 2024 10:35
@faraazb faraazb requested review from hiteshshetty-dev, csAyushDubey and Deepak-Kharah and removed request for a team July 8, 2024 10:35
hiteshshetty-dev
hiteshshetty-dev approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@faraazb faraazb merged commit 0702852 into VC-115/live-editor-support Jul 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiteshshetty-dev hiteshshetty-dev hiteshshetty-dev approved these changes

@csAyushDubey csAyushDubey Awaiting requested review from csAyushDubey

@Deepak-Kharah Deepak-Kharah Awaiting requested review from Deepak-Kharah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faraazb @hiteshshetty-dev