-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: enhance Dockerfiles and entrypoint scripts, update dependen… #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cies, and improve error handling in migration services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors Docker configurations and enhances migration services with improved error handling and file processing capabilities. The changes focus on enhancing security, updating dependencies, and improving the file processing workflow in the migration system.
- Enhanced Dockerfiles with non-root user security practices and updated Node.js versions
- Improved file processing logic to handle nested file paths and return file location information
- Added environment file creation functionality and updated dependencies
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/src/services/fileProcessing.ts | Modified to return file path information from saveZip function |
| upload-api/src/routes/index.ts | Updated file path construction logic to handle nested directories |
| upload-api/src/helper/index.ts | Enhanced saveZip function to track and return saved file paths |
| upload-api/src/controllers/sitecore/index.ts | Improved error handling in createLocaleSource function |
| upload-api/docker-entrypoint.sh | Added entrypoint script for permission management |
| upload-api/Dockerfile | Enhanced security with non-root user and updated Node.js version |
| ui/Dockerfile | Applied similar security enhancements as upload-api |
| ui/.dockerignore | Expanded ignore patterns for better build optimization |
| docker-compose.yml | Added security options to prevent privilege escalation |
| api/src/services/sitecore.service.ts | Added createEnvironment function for environment file creation |
| api/src/services/migration.service.ts | Integrated environment creation into migration workflow |
| api/package.json | Updated @contentstack/cli dependency version |
| api/Dockerfile | Applied security enhancements with non-root user |
| .dockerignore | Enhanced ignore patterns for root-level builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
…cies, and improve error handling in migration services