Skip to content

Conversation

@umeshmore45
Copy link
Contributor

…t script Changed Path change line seq of file from CRLF TO LF

…t script Changed Path change line seq of file from CRLF TO LF
@umeshmore45 umeshmore45 requested a review from a team as a code owner August 18, 2025 13:13
@umeshmore45 umeshmore45 requested a review from Copilot August 18, 2025 13:13
@umeshmore45 umeshmore45 merged commit 27c3bab into dev Aug 18, 2025
7 checks passed
@umeshmore45 umeshmore45 deleted the bugfix/CRLFtoLF branch August 18, 2025 13:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Docker configuration issues by updating the ENTRYPOINT path to use an absolute path and adding error handling to prevent container startup failures due to permission issues.

  • Updated ENTRYPOINT to use absolute path /usr/local/bin/docker-entrypoint.sh instead of relative path
  • Added error handling (|| true) to the chown command to prevent container startup failures when permission changes fail
  • Fixed line ending format from CRLF to LF in the entrypoint script

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
upload-api/Dockerfile Updated ENTRYPOINT to use absolute path for better reliability
upload-api/docker-entrypoint.sh Added error handling to chown command to prevent startup failures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.


# Fix permissions for extracted_files volume at runtime
chown -R nodeapp:nodeapp /app/extracted_files
chown -R nodeapp:nodeapp /app/extracted_files || true
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using || true to suppress all errors from the chown command could hide legitimate security issues. Consider checking if the directory exists first or only suppressing specific expected errors (e.g., chown -R nodeapp:nodeapp /app/extracted_files 2>/dev/null || [ -d /app/extracted_files ]).

Suggested change
chown -R nodeapp:nodeapp /app/extracted_files || true
[ -d /app/extracted_files ] && chown -R nodeapp:nodeapp /app/extracted_files

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants