Bugfix/beta release #773
Bugfix/beta release #773
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR contains bugfixes and improvements for a beta release, focusing on organization data management, UI tooltips, and language mapping functionality.
- Added organization data clearing functionality to prevent stale data between user sessions
- Fixed tooltip positioning and button styling in the ContentMapper component
- Improved language mapping logic and loading state management
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/store/slice/authSlice.tsx | Added clearOrganisationData action to reset organization state |
| ui/src/pages/Login/index.tsx | Integrated organization data clearing on successful login |
| ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx | Enhanced mapping logic and fixed loading state initialization |
| ui/src/components/ContentMapper/index.tsx | Updated tooltip positioning and added CSS class for button styling |
| ui/src/components/ContentMapper/index.scss | Added icon-padding class for button spacing |
| ui/src/components/AdvancePropertise/index.scss | Removed debug styling for select menu |
| .talismanrc | Updated checksum for LoadLanguageMapper.tsx file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| else if ( !isLabelMismatch && !isStackChanged ) { | ||
| const key = `${locale?.label}-master_locale` | ||
| updatedSelectedMappings = { | ||
| [key]: updatedSelectedMappings?.[`${locale?.label}-master_locale`] ? updatedSelectedMappings?.[`${locale?.label}-master_locale`] : '', | ||
| }; | ||
| setSelectedMappings(updatedSelectedMappings); | ||
| } |
There was a problem hiding this comment.
The mapping logic duplicates the key construction ${locale?.label}-master_locale and has inconsistent indentation. Consider extracting the key to a variable and fixing the indentation of the object assignment.
| .icon-padding{ | ||
| padding: 10px 10px; | ||
| margin-left: 6px; | ||
| } |
There was a problem hiding this comment.
The padding shorthand 10px 10px can be simplified to just 10px since both vertical and horizontal values are the same.
No description provided.