-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: enable GitHub App authentication for review workflows #7382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30c0082 to
698652e
Compare
AI Code ReviewAI review completed but failed to parse output No specific line comments generated. 💡 To request a new detailed review, comment |
|
💡 To request a new review, comment |
698652e to
dac1a4f
Compare
| steps: | ||
| - name: Generate GitHub App Token | ||
| id: app-token | ||
| uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69 # v2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This latest v2 provides short live tokens (expire within an hour of the action run).
dac1a4f to
8bc0de8
Compare
8bc0de8 to
6cad07a
Compare
Enable Continue Agent bot identity for PR reviews by generating GitHub App tokens in workflows. Reviews will now appear as continue-agent[bot] instead of github-actions[bot] for better branding and improved rate limits. - Generate app token using actions/create-github-app-token@v1 - Pass token via GITHUB_TOKEN env var to action steps - Uses existing CONTINUE_APP_ID and CONTINUE_APP_PRIVATE_KEY secrets
6cad07a to
29bfc23
Compare
AI Code ReviewAI review completed but failed to parse output No specific line comments generated. 💡 To request a new detailed review, comment |
|
💡 To request a new review, comment |
AI Code ReviewAI review completed but failed to parse output No specific line comments generated. 💡 To request a new detailed review, comment |
|
💡 To request a new review, comment |
cb88db4 to
a889461
Compare
AI Code ReviewAI review completed but failed to parse output No specific line comments generated. 💡 To request a new detailed review, comment |
|
💡 To request a new review, comment |
AI Code ReviewAI review completed but failed to parse output No specific line comments generated. 💡 To request a new detailed review, comment |
|
💡 To request a new review, comment |
fc73a20 to
0747efa
Compare
|
@tomasz-stefaniak The continue-agent isn't commenting with the GitHub App token yet because the workflows are pinned to an old commit (64bda6b). I did pin it to this branch to get the comment to show, and have now reverted the pin. After this PR is merged, the workflow files will need to be updated to reference the new commit SHA to enable the GitHub App authentication for comments. |
You can make this SHA change on this branch - the commit SHA doesn't need to be on main for this to work, and we don't squash before merging. For example, you can use the SHA of "revert: revert the commit pinning to this branch" - |
Update both review workflows to use commit SHA 0747efa instead of branch reference to enable continue-agent bot authentication
|
@tomasz-stefaniak updated the sha |
|
Main is merged |
|
Closing in favor to the changes @sestinj has in progress. |
Description
This PR enables GitHub App authentication for the Continue review workflows, building on the groundwork from #7228. Reviews will now be posted as
continue-agent[bot]instead ofgithub-actions[bot].Context
This is a focused follow-up to #7228, keeping the implementation simple for a quick review. Rather than modifying the action files themselves, we're generating the GitHub App token directly in the workflows and passing it via the
GITHUB_TOKENenvironment variable.Changes
actions/create-github-app-token@v1in both review workflowsGITHUB_TOKENenvironment variableCONTINUE_APP_ID(variable) andCONTINUE_APP_PRIVATE_KEY(secret)Benefits
continue-agent[bot]Testing
I've been testing this on my personal repo, also note the continue-agent is under my personal org. I can transfer once approved and merged.
bdougie/contributor.info#517 (comment)
Related
cc @tomasz-stefaniak
Summary by cubic
Enable GitHub App authentication for the Continue review workflows so reviews post as continue-agent[bot] and benefit from higher API rate limits.