-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Decouple anonymous telemetry from CONTINUE_CLI_ENABLE_TELEMETRY environment variable #8126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
…y control Separates control of OTEL telemetry and anonymous PostHog telemetry: - CONTINUE_CLI_ENABLE_TELEMETRY: Controls OTEL telemetry (requires OTEL config) - CONTINUE_ALLOW_ANONYMOUS_TELEMETRY: Controls anonymous PostHog telemetry This allows users to independently control: 1. OTEL metrics (opt-in via config + env var) 2. Anonymous telemetry (opt-out via env var) Changes: - Added CONTINUE_ALLOW_ANONYMOUS_TELEMETRY env var - Updated posthogService to use new env var - Kept CONTINUE_CLI_ENABLE_TELEMETRY for OTEL control - Updated documentation for both telemetry types - Updated all tests to reflect the change Generated with [Continue](https://continue.dev) Co-authored-by: tingwai <tingwai@continue.dev>
f48e121 to
73057d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
|
|
||
| get isEnabled() { | ||
| return process.env.CONTINUE_CLI_ENABLE_TELEMETRY !== "0"; | ||
| return process.env.CONTINUE_ALLOW_ANONYMOUS_TELEMETRY !== "0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't right, its changing the flag name for enabling posthog telemetry. We should be changing the flag name for wherever OTEL is enabled
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
This PR decouples OpenTelemetry (OTEL) metrics from the
CONTINUE_CLI_ENABLE_TELEMETRYenvironment variable in the Continue CLI.Context
From Slack discussion: https://continuedev.slack.com/archives/C096032ATNG/p1759420638004449?thread_ts=1759420638.004449&cid=C096032ATNG
OTEL is already opt-in because users must explicitly add destination info (e.g.,
OTEL_EXPORTER_OTLP_ENDPOINT,OTEL_METRICS_EXPORTER). TheCONTINUE_CLI_ENABLE_TELEMETRYenvironment variable should only control anonymous telemetry (PostHog), not OTEL.Changes
CONTINUE_CLI_ENABLE_TELEMETRYfrom OTEL initializationCONTINUE_CLI_ENABLE_TELEMETRYfrom the OTEL configuration documentationBehavior
Before
CONTINUE_CLI_ENABLE_TELEMETRY=0, even if OTEL config was presentAfter
CONTINUE_CLI_ENABLE_TELEMETRYnow only affects PostHog anonymous telemetryTesting
Existing tests should continue to pass as they already set
OTEL_METRICS_EXPORTERwhich is the actual control for OTEL.This agent session was co-authored by tingwai and Continue.
Summary by cubic
Decoupled OTEL metrics from CONTINUE_CLI_ENABLE_TELEMETRY so OTEL is controlled only by OTEL env vars. This lets users disable anonymous telemetry while still using OTEL (aligns with CON-4291).