Skip to content

feat: Enhance autocomplete cache with async initialization and improved eviction logic #8367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Enhance autocomplete cache with async initialization and improved eviction logic #8367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0432315
feat: enhance autocomplete cache with async initialization and improv…
Ayyanaruto Oct 21, 2025
52ebf5d
fix: improve async-mutex mocking and reset instancePromise on cache c…
Ayyanaruto Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions core/autocomplete/CompletionProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import AutocompleteLruCache from "./util/AutocompleteLruCache.js";
import { HelperVars } from "./util/HelperVars.js";
import { AutocompleteInput, AutocompleteOutcome } from "./util/types.js";

const autocompleteCache = AutocompleteLruCache.get();
const autocompleteCachePromise = AutocompleteLruCache.get();

// Errors that can be expected on occasion even during normal functioning should not be shown.
// Not worth disrupting the user to tell them that a single autocomplete request didn't go through
Expand All @@ -31,7 +31,7 @@ const ERRORS_TO_IGNORE = [
];

export class CompletionProvider {
private autocompleteCache = AutocompleteLruCache.get();
private autocompleteCache?: AutocompleteLruCache;
public errorsShown: Set<string> = new Set();
private bracketMatchingService = new BracketMatchingService();
private debouncer = new AutocompleteDebouncer();
Expand All @@ -48,6 +48,22 @@ export class CompletionProvider {
) {
this.completionStreamer = new CompletionStreamer(this.onError.bind(this));
this.contextRetrievalService = new ContextRetrievalService(this.ide);
void this.initCache();
}

private async initCache() {
try {
this.autocompleteCache = await autocompleteCachePromise;
} catch (e) {
console.error("Failed to initialize autocomplete cache:", e);
}
}

private async getCache(): Promise<AutocompleteLruCache> {
if (!this.autocompleteCache) {
this.autocompleteCache = await autocompleteCachePromise;
}
return this.autocompleteCache;
}

private async _prepareLlm(): Promise<ILLM | undefined> {
Expand Down Expand Up @@ -201,14 +217,12 @@ export class CompletionProvider {

// Completion
let completion: string | undefined = "";

const cache = await autocompleteCache;
const cache = await this.getCache();
const cachedCompletion = helper.options.useCache
? await cache.get(helper.prunedPrefix)
: undefined;
let cacheHit = false;
if (cachedCompletion) {
// Cache
cacheHit = true;
completion = cachedCompletion;
} else {
Expand Down Expand Up @@ -277,16 +291,12 @@ export class CompletionProvider {
outcome.enabledStaticContextualization = true;
}

//////////

// Save to cache
if (!outcome.cacheHit && helper.options.useCache) {
(await this.autocompleteCache)
void cache
.put(outcome.prefix, outcome.completion)
.catch((e) => console.warn(`Failed to save to cache: ${e.message}`));
}

// When using the JetBrains extension, Mark as displayed
const ideType = (await this.ide.getIdeInfo()).ideType;
if (ideType === "jetbrains") {
this.markDisplayed(input.completionId, outcome);
Expand All @@ -299,4 +309,10 @@ export class CompletionProvider {
this.loggingService.deleteAbortController(input.completionId);
}
}

public async dispose() {
if (this.autocompleteCache) {
await this.autocompleteCache.close();
}
}
}
Loading
Loading