refactor: ♻️ Refactor the cli Tool type to align better with core #8374
+246
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 21 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="extensions/cli/src/tools/index.tsx">
<violation number="1" location="extensions/cli/src/tools/index.tsx:253">
Iterating over the schema object means you only ever see keys like "type" and "properties", so required argument names are never checked. Please iterate over `tool.function.parameters.properties` instead.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
- Fixed validateToolCallArgsPresent to iterate over tool.function.parameters.properties
- Previously iterated over schema object keys like 'type' and 'properties'
- Now correctly validates actual parameter names against required arguments
- Added null safety with ?? {} fallback for undefined properties
Generated with [Continue](https://continue.dev)
Co-Authored-By: Continue <noreply@continue.dev>
- Resolved conflicts in tools/index.tsx preserving both refactor and validation fix - Fixed permission checker to use ALL_BUILT_IN_TOOLS consistently - Updated stream handlers to use new getAllAvailableTools API - Removed deleted test file and cleaned up merge artifacts - Preserved the tool parameter validation fix (properties iteration) Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
dosubot
bot
added
size:L
- Fixed formatting in searchCode.ts and writeChecklist.test.ts - Ensures code style compliance with project standards Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed the CLI and Core "Tool" type had a misaslignment around how a function was defined. This change aligns the function defintion making it easier to share tools between core and the cli. Also eliminates potential issues in the OpenAPI adapters when using tools between core and the cli.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
Updated tests as needed.
Summary by cubic
Refactors the CLI Tool type to use a function schema (type: "function" with function {name, description, parameters}), aligning with core and preventing mismatches. This makes tools shareable between core and CLI and avoids OpenAPI adapter issues.
Refactors
Migration