fix: prevent claude 3 thoughts #8415
Closed
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
✅ Review Complete Code Review Summary |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="core/llm/autodetect.ts">
<violation number="1" location="core/llm/autodetect.ts:149">
This guard now disables reasoning for Claude 3.7 models because their identifiers contain "-3-", so modelSupportsReasoning returns false and reasoning is incorrectly turned off for those models.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| if ("anthropic" === model.underlyingProviderName) { | ||
| if ( | ||
| model.model.includes("claude") && | ||
| !model.model.includes("-3-") && |
There was a problem hiding this comment.
This guard now disables reasoning for Claude 3.7 models because their identifiers contain "-3-", so modelSupportsReasoning returns false and reasoning is incorrectly turned off for those models.
Prompt for AI agents
Address the following comment on core/llm/autodetect.ts at line 149:
<comment>This guard now disables reasoning for Claude 3.7 models because their identifiers contain "-3-", so modelSupportsReasoning returns false and reasoning is incorrectly turned off for those models.</comment>
<file context>
@@ -144,7 +144,11 @@ function modelSupportsReasoning(
- if ("anthropic" === model.underlyingProviderName) {
+ if (
+ model.model.includes("claude") &&
+ !model.model.includes("-3-") &&
+ !model.model.includes("-3.5-")
+ ) {
</file context>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable thinking for 3/3.5
Original author @uinstinct
#8303
having build issues