Skip to content

Remove error handler registration from plugin.xml #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

Remove error handler registration from plugin.xml #8513

merged 1 commit into from
Oct 30, 2025
+0 −1

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Oct 30, 2025 •
edited
Loading

fixes CON-4679

Summary by cubic

Removed the custom error handler from plugin.xml to stop using ContinueErrorSubmitter. The plugin now relies on IntelliJ’s default error reporting to avoid conflicts and unexpected error dialogs.

@sestinj sestinj requested a review from a team as a code owner October 30, 2025 01:00
@sestinj sestinj requested review from tingwai and removed request for a team October 30, 2025 01:00
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

✅ Review Complete

Code Review Summary

⚠️ Continue API authentication failed. Please check your CONTINUE_API_KEY.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2025
@sestinj sestinj merged commit 4425be3 into main Oct 30, 2025
57 of 60 checks passed
@sestinj sestinj deleted the nate/remove-error-handler-registration branch October 30, 2025 05:33
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@tingwai tingwai tingwai approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sestinj @tingwai