-
Notifications
You must be signed in to change notification settings - Fork 3.9k
chore: add support for grok 4.1 fast #8831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/llm-info/src/providers/xAI.ts">
<violation number="1" location="packages/llm-info/src/providers/xAI.ts:58">
`Grok 4.1 Fast Non Reasoning` reuses the reasoning model id, so consumers will never send requests to the non‑reasoning backend. The `model` string in this block should include `-non-reasoning`.</violation>
<violation number="2" location="packages/llm-info/src/providers/xAI.ts:72">
This addition duplicates the existing `grok-4` model entry defined a few lines above, creating two identical configurations for the same model id. Remove the new block or consolidate so each model id appears only once.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, also can we
- add to the add models form in GUI
- add it to recommended agent models i.e. make sure it gets multi edit tool
- add comments about how the model was tested e.g. does it do well in agent mode? both CLI and extensions?
- make sure it's added to auto tool support
- update the docs
|
Also tested grok 4.1 on cn and it worked well. Hence added support for it in the cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 7 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/llm-info/src/providers/xAI.ts">
<violation number="1" location="packages/llm-info/src/providers/xAI.ts:58">
`grok-4-1-fast-*` models are unreachable because the preceding `grok-4` regex (`/grok-4/`) matches their names first, so `findLlmInfo` always returns the `grok-4` entry. Move these entries before `grok-4` or tighten the `grok-4` regex (e.g., `/^grok-4$/`) so the new models can actually be selected.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
…instinct/grok-4.1-support
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
support for new grok 4.1
resolves CON-4961
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Add support for xAI Grok 4.1 Fast models and update docs to recommend Grok‑4 for chat, resolving CON‑4961. Also adds Grok 4.1 Fast to CometAPI and increases Grok 4 (07‑09) context to 256k.
Written for commit d71a59c. Summary will update automatically on new commits.