fix: cn mcp bugs #8899

sestinj · 2025-11-26T19:08:49Z

Description

this fixes a number of bugs that were causing cn to stop (and devboxes too) when MCPs were used that relied on environment variables as secrets

AI Code Review

Team members only: AI review runs automatically when PR is opened or marked ready for review
Team members can also trigger a review by commenting @continue-review

Checklist

[] I've read the contributing guide
[] The relevant docs, if any, have been updated or created
[] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

Summary by cubic

Fixes secret resolution for MCP servers by falling back to local environment variables when org/package secrets aren’t accessible, preventing cn/devboxes from crashing. Also hardens template variable handling, improves error logging, and documents the fallback behavior for clarity.

Bug Fixes
- Merge API secret results only when a value is present; otherwise look up .env to allow env var overrides.
- Use decodeFQSN for secret parsing in MCPService to correctly extract secret names.
- Add defensive guards to getTemplateVariables/fillTemplateVariables and skip invalid inputs during unroll to avoid crashes.
Reliability
- Improve unhandled promise rejection logging, serialize Error objects for readable stacks, and centralize Sentry capture to avoid duplicates.

^{Written for commit 15fb54c. Summary will update automatically on new commits.}

continue-development-app · 2025-11-26T19:08:52Z

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

github-actions · 2025-11-26T19:09:20Z

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.

Adds documentation explaining how the CLI resolves secrets for MCP servers, including the fallback from org/package secrets to local environment variables. This documents the fix from PR #8899 that allows env vars to override inaccessible org secrets in devboxes and restricted environments. Co-authored-by: nate <nate@continue.dev> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>

continue · 2025-11-26T19:13:45Z

Added documentation for the MCP secret resolution changes in extensions/cli/spec/mcp.md:

Documents the new fallback behavior where local environment variables can override org/package secrets that aren't accessible locally
Explains the priority order for secret resolution (API secrets first, then local env vars)
Lists the .env file priority order (process.env → ~/.continue/.env → workspace/.continue/.env → workspace/.env)
Clarifies this fixes MCP server crashes in devboxes and restricted environments where org secrets aren't accessible

The documentation maintains the same level of detail as the existing spec and focuses on the practical implications of the fix.

cubic-dev-ai

1 issue found across 6 files

Prompt for AI agents (all 1 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="extensions/cli/src/index.ts">

<violation number="1" location="extensions/cli/src/index.ts:103">
Passing the Error into `logger.error` causes it to call `sentryService.captureException`, so the explicit capture below now fires twice per rejection, producing duplicate Sentry events.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

cubic-dev-ai · 2025-11-26T19:15:22Z

extensions/cli/src/index.ts

+
+  // If reason is an Error, use it directly for better stack traces
+  if (reason instanceof Error) {
+    logger.error("Unhandled Promise Rejection", reason, errorDetails);


Passing the Error into logger.error causes it to call sentryService.captureException, so the explicit capture below now fires twice per rejection, producing duplicate Sentry events.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At extensions/cli/src/index.ts, line 103: <comment>Passing the Error into `logger.error` causes it to call `sentryService.captureException`, so the explicit capture below now fires twice per rejection, producing duplicate Sentry events.</comment> <file context> @@ -91,7 +91,26 @@ export function shouldShowExitMessage(): boolean { + + // If reason is an Error, use it directly for better stack traces + if (reason instanceof Error) { + logger.error("Unhandled Promise Rejection", reason, errorDetails); + } else { + // Convert non-Error reasons to Error for consistent handling </file context>

✅ Addressed in 4ec2b1b

cubic-dev-ai

1 issue found across 7 files

Prompt for AI agents (all 1 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="extensions/cli/src/index.ts">

<violation number="1" location="extensions/cli/src/index.ts:103">
Passing the Error object into `logger.error` causes that helper to capture the exception with Sentry while the handler still calls `sentryService.captureException`, so every unhandled rejection is reported twice. Remove one of the captures or log the details without treating the argument as an `Error` to avoid duplicate alerts.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

cubic-dev-ai · 2025-11-26T19:18:57Z

extensions/cli/src/index.ts

+
+  // If reason is an Error, use it directly for better stack traces
+  if (reason instanceof Error) {
+    logger.error("Unhandled Promise Rejection", reason, errorDetails);


Passing the Error object into logger.error causes that helper to capture the exception with Sentry while the handler still calls sentryService.captureException, so every unhandled rejection is reported twice. Remove one of the captures or log the details without treating the argument as an Error to avoid duplicate alerts.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At extensions/cli/src/index.ts, line 103: <comment>Passing the Error object into `logger.error` causes that helper to capture the exception with Sentry while the handler still calls `sentryService.captureException`, so every unhandled rejection is reported twice. Remove one of the captures or log the details without treating the argument as an `Error` to avoid duplicate alerts.</comment> <file context> @@ -91,7 +91,26 @@ export function shouldShowExitMessage(): boolean { + + // If reason is an Error, use it directly for better stack traces + if (reason instanceof Error) { + logger.error("Unhandled Promise Rejection", reason, errorDetails); + } else { + // Convert non-Error reasons to Error for consistent handling </file context>

✅ Addressed in 4ec2b1b

…ntinue into nate/cn-mcp-fixes

sestinj · 2025-11-26T19:49:15Z

🎉 This PR is included in version 1.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sestinj · 2025-11-26T20:41:51Z

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sestinj · 2025-12-04T22:13:11Z

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sestinj added 4 commits November 26, 2025 11:03

fix: fall back to env vars

1f44a3d

fix: improved unhandled error logging

fa96e30

fix: unroll edge cases

d045072

fix: mcp secret loading bug

63489e9

sestinj requested a review from a team as a code owner November 26, 2025 19:08

sestinj requested review from tingwai and removed request for a team November 26, 2025 19:08

github-project-automation bot added this to Issues and PRs Nov 26, 2025

github-project-automation bot moved this to Todo in Issues and PRs Nov 26, 2025

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 26, 2025

sestinj requested review from RomneyDa and removed request for tingwai November 26, 2025 19:11

cubic-dev-ai bot reviewed Nov 26, 2025

View reviewed changes

sestinj added 2 commits November 26, 2025 11:46

fix: no duplicate sentry error

4ec2b1b

Merge branch 'nate/cn-mcp-fixes' of https://github.com/continuedev/co…

15fb54c

…ntinue into nate/cn-mcp-fixes

sestinj merged commit 0dd7402 into main Nov 26, 2025
30 of 35 checks passed

github-project-automation bot moved this from Todo to Done in Issues and PRs Nov 26, 2025

sestinj deleted the nate/cn-mcp-fixes branch November 26, 2025 19:46

github-actions bot locked and limited conversation to collaborators Nov 26, 2025

sestinj added the released label Nov 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: cn mcp bugs #8899

fix: cn mcp bugs #8899

sestinj commented Nov 26, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

continue-development-app bot commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

continue bot commented Nov 26, 2025

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Nov 26, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Nov 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

sestinj commented Nov 26, 2025

Uh oh!

sestinj commented Nov 26, 2025

Uh oh!

sestinj commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: cn mcp bugs #8899

fix: cn mcp bugs #8899

Conversation

sestinj commented Nov 26, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

AI Code Review

Checklist

Screen recording or screenshot

Tests

Summary by cubic

Uh oh!

continue-development-app bot commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Uh oh!

continue bot commented Nov 26, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sestinj commented Nov 26, 2025

Uh oh!

sestinj commented Nov 26, 2025

Uh oh!

sestinj commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sestinj commented Nov 26, 2025 •

edited by cubic-dev-ai bot

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading

cubic-dev-ai bot Nov 26, 2025 •

edited

Loading

cubic-dev-ai bot Nov 26, 2025 •

edited

Loading