Skip to content

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Nov 28, 2025

Summary by cubic

Adds automatic refresh for storage sync pre-signed URLs to prevent expiry-related upload failures. The CLI refreshes proactively at 50 minutes and reacts to 403 errors, with safe concurrency and improved error handling.

  • New Features
    • Tracks URL expiration and schedules refresh 10 minutes before expiry.
    • Triggers an immediate refresh when uploads return 403 Forbidden.
    • Prevents concurrent refresh calls with a lock; reschedules after successful refresh.
    • Clears refresh timers on stop and logs upload errors without stopping the service.
    • Updates docs with the URL Refresh Strategy and adds tests for 403-triggered refresh and concurrency.

Written for commit 02c3cc3. Summary will update automatically on new commits.

@sestinj sestinj requested a review from a team as a code owner November 28, 2025 21:47
@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@sestinj sestinj requested review from Patrick-Erichsen and removed request for a team November 28, 2025 21:47
@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 28, 2025
@github-actions
Copy link

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Documentation review completed. The PR already includes appropriate documentation updates in extensions/cli/docs/storage-sync.md:

  • Updated the expiration section to reflect the 60-minute TTL
  • Added a new "URL Refresh Strategy" section explaining the dual-strategy approach (proactive + reactive refresh)
  • Removed the resolved item from "Open Questions & Future Enhancements"

The documentation changes are well-scoped and maintain consistency with the existing document structure. No additional documentation updates are needed.

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@sestinj sestinj merged commit d3652a4 into main Nov 28, 2025
60 checks passed
@sestinj sestinj deleted the nate/storage-sync-url-refresh branch November 28, 2025 22:07
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Nov 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Dec 1, 2025

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Dec 2, 2025

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Dec 2, 2025

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Dec 4, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant