-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: HOTFIX gemini model add form #8954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
2 similar comments
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
✅ Review Complete Code ReviewThis is a straightforward hotfix that removes a nonexistent model reference ( ✅ Overall Assessment: This fix is appropriate and addresses the immediate issue. Observations:
Suggested Follow-up (separate PR): // Example validation to prevent this issue:
const validateProviderModels = () => {
providers.forEach(provider => {
provider.models.forEach(model => {
if (!model.model) {
throw new Error(`Invalid model reference in ${provider.provider}`);
}
});
});
};The fix itself is correct for a hotfix. The multiple related issues (#8896, #8846, #8893, #8880, #8943, #8932, #8946, #8947) suggest this was causing significant user impact, so shipping this quickly makes sense. |
|
Reviewed PR #8954. No documentation updates needed. This is a clean bugfix that removes a non-existent model variant (
The fix correctly unbreaks the form without requiring any documentation changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Nonexistent value for gemini 2.5 pro exp was breaking selector
Fixes #8896, #8846, #8893, #8880, #8943, #8932, #8946, #8947
Let's fix types on this soon so doesn't happen again
Summary by cubic
Fixed the Add New Model selector by removing the nonexistent “Gemini 2.5 Pro Exp” option from the Gemini provider list. This prevents the form from breaking when choosing a Gemini model.
Written for commit bc6f599. Summary will update automatically on new commits.