Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Dec 1, 2025

Description

Nonexistent value for gemini 2.5 pro exp was breaking selector
Fixes #8896, #8846, #8893, #8880, #8943, #8932, #8946, #8947

Let's fix types on this soon so doesn't happen again


Summary by cubic

Fixed the Add New Model selector by removing the nonexistent “Gemini 2.5 Pro Exp” option from the Gemini provider list. This prevents the form from breaking when choosing a Gemini model.

Written for commit bc6f599. Summary will update automatically on new commits.

@RomneyDa RomneyDa requested a review from a team as a code owner December 1, 2025 21:31
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team December 1, 2025 21:31
@continue
Copy link
Contributor

continue bot commented Dec 1, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

2 similar comments
@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

✅ Review Complete

Code Review

This is a straightforward hotfix that removes a nonexistent model reference (models.gemini25ProExp) from the Gemini provider configuration. The change fixes the Add New Model selector that was breaking when users tried to select a Gemini model.

✅ Overall Assessment: This fix is appropriate and addresses the immediate issue.

Observations:

  1. Root Cause: The PR removes a model reference that doesn't exist in the models configuration, which was causing the selector to break. This is the right immediate fix.

  2. Missing Investigation: The PR doesn't show where models.gemini25ProExp was supposed to be defined. Before merging, verify:

    • Was this model definition removed elsewhere?
    • Or was it never properly added?
    • Check models object definition to ensure consistency
  3. Type Safety (as noted in PR description): The fact that this nonexistent reference didn't cause a build-time error suggests missing type checking. Consider:

    • Adding stricter TypeScript checks on the providers.ts configuration
    • Using a type-safe enum or const assertion for model references
    • Adding a build-time validation that all referenced models exist
  4. Testing: Consider adding:

    • A unit test that validates all provider model references exist in the models configuration
    • Basic smoke test for the Add New Model form with Gemini provider

Suggested Follow-up (separate PR):

// Example validation to prevent this issue:
const validateProviderModels = () => {
  providers.forEach(provider => {
    provider.models.forEach(model => {
      if (!model.model) {
        throw new Error(`Invalid model reference in ${provider.provider}`);
      }
    });
  });
};

The fix itself is correct for a hotfix. The multiple related issues (#8896, #8846, #8893, #8880, #8943, #8932, #8946, #8947) suggest this was causing significant user impact, so shipping this quickly makes sense.


@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 1, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 1, 2025
@continue
Copy link
Contributor

continue bot commented Dec 1, 2025

Reviewed PR #8954. No documentation updates needed.

This is a clean bugfix that removes a non-existent model variant (gemini25ProExp) from the Add New Model form dropdown. The existing documentation references are:

  • Gemini 2.5 Pro (not "Exp") - a valid model with hub link at https://hub.continue.dev/google/gemini-2.5-pro
  • Documentation shows manual configuration via Mission Control, which is unaffected by this UI dropdown change
  • No docs reference the removed experimental variant

The fix correctly unbreaks the form without requiring any documentation changes.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@RomneyDa RomneyDa merged commit b52603b into main Dec 1, 2025
57 of 60 checks passed
@RomneyDa RomneyDa deleted the dallin/gemini-add-model-hotfix branch December 1, 2025 21:54
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Dec 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
@RomneyDa RomneyDa added the hotfix Should be considered as a hotfix for main releases label Dec 1, 2025
@sestinj
Copy link
Contributor

sestinj commented Dec 1, 2025

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Dec 2, 2025

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Dec 2, 2025

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Dec 4, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hotfix Should be considered as a hotfix for main releases lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'title')

4 participants