Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Dec 1, 2025

Description

A new "nonbreaking" version of vector db uses a newer version of lancedb which stores the binary files at e.g. node_modules/@lancedb/lancedb-darwin-arm64/lancedb.darwin-arm64.node which fails because the prepackage script is expecting node_modules/@lancedb/lancedb-darwin-arm64/index.node


Summary by cubic

Pinned vectordb to 0.4.20 to stop build failures caused by an upstream lancedb native file rename. This keeps our prepackage script working and restores packaging.

  • Bug Fixes
    • Set vectordb to exact "0.4.20" (no caret) in binary, core, and VSCode extension.
    • Prevents pulling newer vectordb where lancedb changes native path from index.node to lancedb..node, which breaks our prepackage step.

Written for commit 51a374c. Summary will update automatically on new commits.

@RomneyDa RomneyDa requested a review from a team as a code owner December 1, 2025 22:30
@RomneyDa RomneyDa removed the request for review from a team December 1, 2025 22:30
@RomneyDa RomneyDa requested a review from sestinj December 1, 2025 22:30
@continue
Copy link
Contributor

continue bot commented Dec 1, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

2 similar comments
@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@continue-development-app
Copy link

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 1, 2025
@RomneyDa RomneyDa changed the title fix: pin vectordb fix: HOTFIX pin vectordb Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

✅ Review Complete

This is a hotfix PR that pins the vectordb dependency to exact version 0.4.20 to prevent build failures caused by a breaking change in newer versions where lancedb moved native binary files to a different path.

Assessment: Approved - This is a proper hotfix with one minor suggestion

Key Changes

  • Pins vectordb from ^0.4.20 to 0.4.20 (exact version) in:
    • binary/package.json
    • core/package.json
    • extensions/vscode/package.json

Issues Found

None. The fix appropriately addresses the immediate problem.

Minor Suggestions

  1. Follow-up work needed: While this hotfix is correct for stopping the bleeding, consider:

    • Filing an issue to update the prepackage script to handle the new lancedb binary path structure
    • Investigating whether to upgrade to the newer lancedb version once the prepackage script is fixed
    • Documenting the version pin reason in code comments (e.g., in package.json or the prepackage script)
  2. Lock file drift: The package-lock.json shows updates to other packages (e.g., @continuedev/openai-adapters, semantic-release) that seem unrelated to the vectordb fix. This could have been caused by npm's automatic lock file updates. Consider:

    • Ensuring these changes are intentional
    • If not, consider regenerating the lock file with just the vectordb change

Summary

The core fix is solid and appropriate for a hotfix. The exact version pin will prevent automatic upgrades to problematic versions. The broader lock file changes should be verified but don't affect the hotfix's validity.


@continue
Copy link
Contributor

continue bot commented Dec 1, 2025

Reviewed PR #8956. This is an internal build fix that pins vectordb to 0.4.20 to prevent packaging failures. No documentation updates are needed because:

  • The change only affects the build/packaging process (prepackage script expecting index.node file path)
  • No user-facing features or APIs are impacted
  • The docs that mention LanceDB (faqs.mdx, custom-code-rag.mdx) refer to user functionality and user-managed instances, not Continue's internal vectordb dependency version

The PR can proceed without doc changes.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 1, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 1, 2025
@RomneyDa RomneyDa merged commit 60879a5 into main Dec 1, 2025
59 of 60 checks passed
@RomneyDa RomneyDa deleted the dallin/pin-vectordb branch December 1, 2025 22:56
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Dec 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
@sestinj
Copy link
Contributor

sestinj commented Dec 1, 2025

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Dec 2, 2025

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Dec 2, 2025

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Dec 4, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants