-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: HOTFIX pin vectordb #8956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HOTFIX pin vectordb #8956
Conversation
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
2 similar comments
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
✅ Review Complete This is a hotfix PR that pins the Assessment: Approved - This is a proper hotfix with one minor suggestion Key Changes
Issues FoundNone. The fix appropriately addresses the immediate problem. Minor Suggestions
SummaryThe core fix is solid and appropriate for a hotfix. The exact version pin will prevent automatic upgrades to problematic versions. The broader lock file changes should be verified but don't affect the hotfix's validity. |
|
Reviewed PR #8956. This is an internal build fix that pins vectordb to 0.4.20 to prevent packaging failures. No documentation updates are needed because:
The PR can proceed without doc changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 6 files
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
A new "nonbreaking" version of vector db uses a newer version of lancedb which stores the binary files at e.g.
node_modules/@lancedb/lancedb-darwin-arm64/lancedb.darwin-arm64.nodewhich fails because the prepackage script is expectingnode_modules/@lancedb/lancedb-darwin-arm64/index.nodeSummary by cubic
Pinned vectordb to 0.4.20 to stop build failures caused by an upstream lancedb native file rename. This keeps our prepackage script working and restores packaging.
Written for commit 51a374c. Summary will update automatically on new commits.