ansible SHA for legacy swarm etcd url #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarm's etcd on workers should be 127.0.0.1 old code had etcd_proxy listen on all interfaces, #376 removed the ETCD_LISTEN_CLIENT_URLS env var that configured that. The proxy only listens on 127.0.0.1, but swarm startup script was pointing to the control interface's IP. Signed-off-by: Chris Plock <chrisplo@cisco.com>
|
build PR |
vhosakot
approved these changes
Dec 11, 2017
tiewei
approved these changes
Dec 12, 2017
|
ansible commit and some testing results: contiv/ansible#383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swarm's etcd on workers should be 127.0.0.1
old code had etcd_proxy listen on all interfaces, #376
removed the ETCD_LISTEN_CLIENT_URLS env var that configured that.
The proxy only listens on 127.0.0.1, but swarm startup script was
pointing to the control interface's IP.
Signed-off-by: Chris Plock chrisplo@cisco.com