[vtbackend] Fixes selecting a single character not working easily (#1066

)

Signed-off-by: Christian Parpart <christian@parpart.family>

metainfo.xml

@@ -107,6 +107,7 @@
       <description>
         <ul>
           <li>Fixes terminfo `tsl` to how todays apps are using it (e.g. zsh) to simply set the window title.</li>
+          <li>Fixes selecting a single character not working easily (#1066).</li>
           <li>Adds `profiles.*.permissions.display_host_writable_statusline` to allow the user to intervene in `DECSSDT` VT sequence to show the host writable statusline even if the indicator statusline is currently active.</li>
           <li>Extends `ViNormalMode` to toggle between insert and normal mode rather than just entering normal mode.</li>
           <li>Modal mode: Adds Return key to also move the cursor down (like vim).</li>

src/vtbackend/InputGenerator.cpp

@@ -788,6 +788,10 @@ bool InputGenerator::generateMouseMove(Modifier modifier,
                                        PixelCoordinate pixelPosition,
                                        bool uiHandled)
 {
+    if (pos == _currentMousePosition && _mouseTransport != MouseTransport::SGRPixels)
+        // Only generate a mouse move event if the coordinate of interest(!) has actually changed.
+        return false;
+
     auto const logged = [&](bool success) -> bool {
         if (success)
         {

src/vtbackend/Selector.cpp

@@ -52,8 +52,6 @@ bool Selection::extend(CellLocation to)
 {
     assert(_state != State::Complete
            && "In order extend a selection, the selector must be active (started).");
-    if (_to == to)
-        return false;
     _state = State::InProgress;
     _to = to;
     _onSelectionUpdated();

src/vtbackend/Terminal.cpp

@@ -768,13 +768,11 @@ void Terminal::sendMouseMoveEvent(Modifier modifier,
         clearSelection();
     }
 
-    // Only continue if he mouse position has changed to a new grid value or we're tracking pixel values.
-    if (newPosition == _currentMousePosition && !isModeEnabled(DECMode::MouseSGRPixels))
-        return;
-
-    _currentMousePosition = newPosition;
-
-    updateCursorHoveringState();
+    if (newPosition != _currentMousePosition)
+    {
+        _currentMousePosition = newPosition;
+        updateCursorHoveringState();
+    }
 
     if (!_leftMouseButtonPressed)
         return;