Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DECSCPP causes the terminal to hang #1205

Closed
j4james opened this issue Sep 19, 2023 · 1 comment · Fixed by #1207
Closed

DECSCPP causes the terminal to hang #1205

j4james opened this issue Sep 19, 2023 · 1 comment · Fixed by #1207
Labels
blocker release-blocking action item bug Something isn't working

Comments

@j4james
Copy link

j4james commented Sep 19, 2023

Contour Terminal version

0.3.12.262

Installer source

GitHub: release page

Operating System

Ubuntu Linux 22.04

Architecture

x86-64

Other Software

No response

Steps to reproduce

Attempt to use the DECSCPP sequence to set the terminal width, e.g. from a bash shell:

printf "\e[132\$|"

Expected Behavior

The width of the terminal should change.

Actual Behavior

The width remains as it was, but the terminals hangs. There is no further output, and it doesn't respond to keypresses. If I try to close the window, I get a message from the OS saying "This window is not responding. Do you want to force the application to exit, or wait for it to respond?"

Additional notes

No response

@j4james j4james added the bug Something isn't working label Sep 19, 2023
@christianparpart
Copy link
Member

On a very quick look, the GUI thread (Qt) and the Terminal I/O thread both try to acquire the lock on the terminal object and wait. This is the freeze I also noticed. What I could not figure out in an instant is why both wait, as in, who's holding the lock. Good question. Many thanks, @j4james. We'll investigate that. This used to work. I wonder if it's possible to add it to our headless integration test suite. 🤔

@christianparpart christianparpart added the blocker release-blocking action item label Sep 19, 2023
christianparpart added a commit that referenced this issue Sep 20, 2023
Signed-off-by: Christian Parpart <christian@parpart.family>
christianparpart added a commit that referenced this issue Sep 20, 2023
Signed-off-by: Christian Parpart <christian@parpart.family>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker release-blocking action item bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants