Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key mappings have stopped working #1408

Closed
T-727 opened this issue Jan 11, 2024 · 11 comments · Fixed by #1434
Closed

key mappings have stopped working #1408

T-727 opened this issue Jan 11, 2024 · 11 comments · Fixed by #1434
Assignees
Labels
bug Something isn't working frontend Contour Terminal Emulator (GUI frontend) good first issue Good for newcomers platform: windows topics that directly address Windows platform

Comments

@T-727
Copy link

T-727 commented Jan 11, 2024

Contour Terminal version

0.4.1.6292

Installer source

something else (please specify below)

Operating System

Windows 11 Home 23H2

Architecture

x86-64

Other Software

No response

Steps to reproduce

  • Open contour
  • Use any keymap (e.g Ctrl+Shift+Space for vi-mode)
  • See that nothing happens

Expected Behavior

No response

Actual Behavior

According to the logs they do get detected:

Debug[default]: sendKeyEvent QKeyEvent(KeyPress, Key_Space, ShiftModifier|ControlModifier, text=" ") ((null):0, (null))

but absolutely nothing happens after

Additional notes

  • last working version for me is 0.3.12.262
  • tried both with default configuration and my own

I know this isn't the most helpful report but I can't find anything to explain this 😅

@T-727 T-727 added the bug Something isn't working label Jan 11, 2024
@Yaraslaut
Copy link
Member

Maybe something is wrong with config file, you can try contour debug config and check the output

@T-727
Copy link
Author

T-727 commented Jan 11, 2024

That was my first thought, hence why I made sure it happens with the default config (contour generate config).

I tried contour debug config now with the default config and there doesn't seem to be anything interesting:
image

@Yaraslaut
Copy link
Member

Yaraslaut commented Jan 11, 2024

Alright, can you try then
contour debug "gui.input,gui.session"
this is what i see for ctr+shift+space

Debug[default]: sendKeyEvent QKeyEvent(KeyPress, Key_Shift, ShiftModifier) ((null):0, (null))
[2024-01-11 17:24:37.336898549.336898] [gui.input] Input not handled for mods Shift key 0x1000020
Debug[default]: sendKeyEvent QKeyEvent(KeyPress, Key_Control, ShiftModifier|ControlModifier) ((null):0, (null))
[2024-01-11 17:24:37.361670882.361670] [gui.input] Key Press event received: Shift|Control LeftControl
Debug[default]: sendKeyEvent QKeyEvent(KeyPress, Key_Space, ShiftModifier|ControlModifier, text="\u0000") ((null):0, (null))
[2024-01-11 17:24:38.395820813.395820] [gui.input] Character Press event received: Shift|Control
[2024-01-11 17:24:38.395836923.395836] [gui.session] executeAction: ViNormalMode

@T-727
Copy link
Author

T-727 commented Jan 11, 2024

Ctrl-Shift-Space:

Debug[default]: sendKeyEvent QKeyEvent(KeyPress, Key_Control, ControlModifier) ((null):0, (null))
[2024-01-11 18:03:21.5519476.551947] [gui.input] Key Press event received:  LeftControl
Debug[default]: sendKeyEvent QKeyEvent(KeyPress, Key_Shift, ShiftModifier|ControlModifier) ((null):0, (null))
[2024-01-11 18:03:22.1505428.150542] [gui.input] Input not handled for mods Shift key 0x1000020
Debug[default]: sendKeyEvent QKeyEvent(KeyPress, Key_Space, ShiftModifier|ControlModifier, text=" ") ((null):0, (null))
[2024-01-11 18:03:22.7821391.782138] [gui.input] Character Press event received: Shift
Debug[default]: sendKeyEvent QKeyEvent(KeyRelease, Key_Space, ShiftModifier|ControlModifier, text=" ") ((null):0, (null))
[2024-01-11 18:03:22.8829204.882920] [gui.input] Character Release event received: Shift
Debug[default]: sendKeyEvent QKeyEvent(KeyRelease, Key_Shift, ControlModifier) ((null):0, (null))
[2024-01-11 18:03:23.5574102.557410] [gui.input] Input not handled for mods  key 0x1000020
Debug[default]: sendKeyEvent QKeyEvent(KeyRelease, Key_Control) ((null):0, (null))
[2024-01-11 18:03:23.5848771.584876] [gui.input] Key Release event received:  LeftControl

seems like no [gui.session] action is triggered

@uspasojevic96
Copy link
Member

@Yaraslaut 0.4.0 works as well, that means its something in 0.4.1

@uspasojevic96 uspasojevic96 added good first issue Good for newcomers frontend Contour Terminal Emulator (GUI frontend) platform: windows topics that directly address Windows platform labels Jan 11, 2024
@Yaraslaut
Copy link
Member

I suspect that this c29a123 caused this regression @christianparpart

@T-727
Copy link
Author

T-727 commented Jan 12, 2024

0.4.0 works as well

Not actually the case for me.
Here's what 0.4.0.6245 output looks like:

[2024-01-12 06:19:22.2372417.237241] [gui.input] Key Press event received:  LeftControl
[2024-01-12 06:19:22.8228477.822847] [gui.input] Input not handled for mods Shift key 0x1000020
[2024-01-12 06:19:23.6207890.620788] [gui.input] Character Press event received: Shift
[2024-01-12 06:19:23.7450652.745065] [gui.input] Character Release event received: Shift
[2024-01-12 06:19:24.4549367.454936] [gui.input] Input not handled for mods  key 0x1000020
[2024-01-12 06:19:24.4771694.477169] [gui.input] Key Release event received:  LeftControl

@uspasojevic96
Copy link
Member

0.4.0 works as well

Not actually the case for me.

Here's what 0.4.0.6245 output looks like:


[2024-01-12 06:19:22.2372417.237241] [gui.input] Key Press event received:  LeftControl

[2024-01-12 06:19:22.8228477.822847] [gui.input] Input not handled for mods Shift key 0x1000020

[2024-01-12 06:19:23.6207890.620788] [gui.input] Character Press event received: Shift

[2024-01-12 06:19:23.7450652.745065] [gui.input] Character Release event received: Shift

[2024-01-12 06:19:24.4549367.454936] [gui.input] Input not handled for mods  key 0x1000020

[2024-01-12 06:19:24.4771694.477169] [gui.input] Key Release event received:  LeftControl

I tested it by running powershell with contour and with wsl

@T-727
Copy link
Author

T-727 commented Jan 12, 2024

I tested with the default config: windows-powershell 5.1, and my own config: powershell 7.4. No wsl

@uspasojevic96
Copy link
Member

ill check the 0.4.0.6245 for me on 5779 it works

@uspasojevic96
Copy link
Member

@Yaraslaut fuckup is between 5779 and 6245 builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Contour Terminal Emulator (GUI frontend) good first issue Good for newcomers platform: windows topics that directly address Windows platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants