Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows alt/control key modifiers #1434

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix Windows alt/control key modifiers #1434

merged 1 commit into from
Jan 29, 2024

Conversation

Yaraslaut
Copy link
Member

Closes #1408

Also, fixes my locall build with libssh support, see target names: libssh2/libssh2#1104

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Jan 28, 2024
@christianparpart christianparpart changed the title Fix/windows Fix Windows alt/control key modifiers Jan 28, 2024
@github-actions github-actions bot removed the frontend Contour Terminal Emulator (GUI frontend) label Jan 29, 2024
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Yaraslaut

@christianparpart
Copy link
Member

CMake Error at src/vtpty/CMakeLists.txt:82 (target_link_libraries):
Error:   Target "vtpty" links to:

    Libssh2::libssh2

  but the target was not found.

I think, on windows, we need the old way, but then explicitly link against the _static version.

@Yaraslaut
Copy link
Member Author

CMake Error at src/vtpty/CMakeLists.txt:82 (target_link_libraries):
Error:   Target "vtpty" links to:

    Libssh2::libssh2

  but the target was not found.

I think, on windows, we need the old way, but then explicitly link against the _static version.

I reverted this commit

@christianparpart christianparpart merged commit eadf41a into master Jan 29, 2024
56 checks passed
@christianparpart christianparpart deleted the fix/windows branch January 29, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key mappings have stopped working
2 participants