Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text buffer capture only works on second attempt #493

Closed
christianparpart opened this issue Nov 3, 2021 · 8 comments · Fixed by #613
Closed

text buffer capture only works on second attempt #493

christianparpart opened this issue Nov 3, 2021 · 8 comments · Fixed by #613
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)
Milestone

Comments

@christianparpart
Copy link
Member

Message: VTE did not respond to CAPTURE 'CSI > Ps; Ps t';
Sometimes it is: "did not start with expected prefix" thing.

For some reason one has to press the keybind twice in order to capture the buffer. Let's fix that!

@christianparpart christianparpart added the bug Something isn't working label Nov 3, 2021
@christianparpart christianparpart added this to the 0.2.x bugfix release milestone Nov 3, 2021
@christianparpart christianparpart added the VT: Backend Virtual Terminal Backend (libterminal API) label Nov 4, 2021
@whisperity
Copy link
Member

#613 did not fix everything, there is something still wrong with more complex prompts such as Zsh with P9k/P10k, etc. Barebones Bash capture does indeed work.

@whisperity whisperity reopened this Feb 27, 2022
@uspasojevic96
Copy link
Member

barebones zsh also works, it's just with complex prompts

@christianparpart
Copy link
Member Author

thx for re-opening. Okay, so what's "complex prompts" then. I'll keep digging this week. I wanted to address the "smal initial-winsize-on-ubuntu18" and "compile-me-on-clang-linux" problem, too. (all 3 this week). let's see how far I'll get. :)

@uspasojevic96
Copy link
Member

Powerline or my prompt

@whisperity
Copy link
Member

@christianparpart I think p9k/p10k should be enough.
The ZSH you're using on stream shall be sufficient too (I observed you use powerline and the "zsh syntax highlighting" plugin.)

I've attached a full debug log from my machine (and my zsh and prompt) on Discord for you 🙂 I think digging into that for the exact VT sequences could give some insight.

@uspasojevic96 Were you able to pin down whether it is the prompt causing the issue, or the Contour ZSH integration script?

@uspasojevic96
Copy link
Member

its not integration, i have disabled it and still had issue

christianparpart added a commit that referenced this issue Mar 20, 2022
@christianparpart
Copy link
Member Author

But now we can close it. (famous last words).

@whisperity
Copy link
Member

So far can confirm it works properly. 😬 What an odd bug. 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants