Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort if displaying sixel and resizing font #642

Closed
kumattau opened this issue Apr 17, 2022 · 2 comments · Fixed by #643
Closed

Abort if displaying sixel and resizing font #642

kumattau opened this issue Apr 17, 2022 · 2 comments · Fixed by #643
Labels
bug Something isn't working VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library

Comments

@kumattau
Copy link

kumattau commented Apr 17, 2022

Contour Terminal version

0.3.0-unreleased-master-bf5976d3

Installer source

Github: source code cloned

Operating System

Ubuntu Linux 20.04

Architecture

x86-64

Other Software

No response

Steps to reproduce

  1. display sixel
  2. resize font (e.g. Ctrl + Plus)

Expected Behavior

Contour Terminal Emulator does not abort.

Actual Behavior

Contour Terminal Emulator aborts with the following message.

/home/user/src/github.com/contour-terminal/contour/src/terminal_renderer/RenderTarget.cpp:46] Precondition failed. bitmap.size() == bitmapSize.area() * atlas::element_count(bitmapFormat)

========================================================================
  An internal error caused the terminal to crash ;-( 😭
-------------------------------------------------------

Please report this to https://github.com/contour-terminal/contour/issues/

Contour version: 0.3.0-unreleased-master-bf5976d3

Stack Trace:
------------
/home/user/src/github.com/contour-terminal/contour/src/crispy/StackTrace.cpp:90
/usr/include/c++/9/bits/stl_vector.h:95
/home/user/src/github.com/contour-terminal/contour/src/contour/ContourApp.cpp:76
/usr/include/c++/9/sstream:832
0x7f7805f0f0c0
0x7f7805f0f03b
0x7f7805eee859
/home/user/src/github.com/contour-terminal/contour/src/crispy/assert.h:52
/home/user/src/github.com/contour-terminal/contour/src/terminal_renderer/ImageRenderer.cpp:79
/home/user/src/github.com/contour-terminal/contour/src/crispy/StrongLRUHashtable.h:629
/home/user/src/github.com/contour-terminal/contour/src/terminal_renderer/ImageRenderer.cpp:87
/home/user/src/github.com/contour-terminal/contour/src/terminal_renderer/ImageRenderer.cpp:53
/usr/include/c++/9/bits/stl_iterator.h:826 (discriminator 3)
/home/user/src/github.com/contour-terminal/contour/src/terminal_renderer/Renderer.cpp:313
/home/user/src/github.com/contour-terminal/contour/src/contour/opengl/TerminalWidget.cpp:578
0x7f7807344e05
0x7f78073222b6
/home/user/src/github.com/contour-terminal/contour/src/contour/opengl/TerminalWidget.cpp:702
0x7f78072dfa66
0x7f78072e90f0
0x7f780669280a
0x7f780731af4a
0x7f780731b799
0x7f780731c423
0x7f780731c306
0x7f780731b4a4
0x7f780731c423
0x7f780731b4a4
0x7f78072f1bfc
0x7f78072f1dc1
0x7f780730a385
0x7f7807322cac
0x7f7807437148
/home/user/src/github.com/contour-terminal/contour/src/contour/TerminalWindow.cpp:218
0x7f78072dfa66
0x7f78072e90f0
0x7f780669280a
0x7f7806695488
0x7f78066eae37
0x7f7805d9b17d
0x7f7805d9b400
0x7f7805d9b4a3
0x7f78066ea435
0x7f78066913ab
0x7f7806699116
/home/user/src/github.com/contour-terminal/contour/src/contour/ContourGuiApp.cpp:322
/usr/include/c++/9/bits/std_function.h:287
/usr/include/c++/9/bits/std_function.h:689
/home/user/src/github.com/contour-terminal/contour/src/crispy/App.cpp:233
/home/user/src/github.com/contour-terminal/contour/src/contour/ContourGuiApp.cpp:67
/home/user/src/github.com/contour-terminal/contour/src/contour/main.cpp:24
x7f7805ef00b3
??:?
========================================================================

Please report the above information and help making this project better.

Additional notes

Contour Terminal Emulator 0.2.3.183 (from GitHub: release page) does not abort with the steps.

@kumattau kumattau added the bug Something isn't working label Apr 17, 2022
@christianparpart
Copy link
Member

Hey @kumattau.

Would you mind trying out the latest release, please (version 0.3.0 in release page should be sufficient).

@christianparpart
Copy link
Member

Ah, I just noticed you're already at Contour version: 0.3.0-unreleased-master-bf5976d3. I'll have a look first.

christianparpart added a commit that referenced this issue Apr 18, 2022
@christianparpart christianparpart added the VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants