Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues with build compiled from master today #821

Closed
Glog78 opened this issue Sep 17, 2022 · 12 comments · Fixed by #823
Closed

Rendering issues with build compiled from master today #821

Glog78 opened this issue Sep 17, 2022 · 12 comments · Fixed by #823
Assignees
Labels
bug Something isn't working fonts font rasterization and text shaping API and platform implementations platform: linux topics that directly address Linux platform (any distro)

Comments

@Glog78
Copy link

Glog78 commented Sep 17, 2022

Contour Terminal version

master

Installer source

Github: source code cloned

Operating System

arch linux

Architecture

x86-64

Other Software

No response

Steps to reproduce

https://i.imgur.com/D3CKJ7k.png

interesting font rendering

Expected Behavior

i think it's obvious

Actual Behavior

wrong glyph rendering

Additional notes

No response

@Glog78 Glog78 added the bug Something isn't working label Sep 17, 2022
@uspasojevic96
Copy link
Member

Thanks for reporting, can you give us copy of your config?

@uspasojevic96 uspasojevic96 added VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library fonts font rasterization and text shaping API and platform implementations platform: linux topics that directly address Linux platform (any distro) and removed VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library labels Sep 17, 2022
@Glog78
Copy link
Author

Glog78 commented Sep 17, 2022

https://termbin.com/7u0z << config

@christianparpart
Copy link
Member

Here it might be very interesting too see the comments of them texture atlas that can be dumped. It looks like the image is uploaded correctly but rendered squeezed, may e due to wrong internal color format passing. But that is very odd.

@uspasojevic96
Copy link
Member

uspasojevic96 commented Sep 18, 2022

Can you post output of fc-match "JetBrainsMono Nerd Font" and fc-match "JetBrainsMono Nerd Font Mono"?

For me it resolves first one to Liberation and I can reproduce your issue, the second one resolved to nerd font properly, so I am thinking that font lookup/fallback might be issue here

@Glog78
Copy link
Author

Glog78 commented Sep 18, 2022

[archbox ~] fc-match "JetBrainsMono Nerd Font"
JetBrains Mono Regular Nerd Font Complete.ttf: "JetBrainsMono Nerd Font" "Regular"
[archbox ~] fc-match "JetBrainsMono Nerd Font Mono"
JetBrains Mono Regular Nerd Font Complete Mono.ttf: "JetBrainsMono Nerd Font Mono" "Regular"

Some more info it's not only one glyph which is rendered strange ... it's also the w which is rendered strange.
On a other sidenote it seems to be only happening when using regular fontwidth and disappear when using bold.

image
^^ see the difference of midnight commander when rendering regular (under the highlighted directory and bold)

@Utkarsh-khambra
Copy link
Collaborator

Does setting font.render_mode to gray fixes it for you?

@Glog78
Copy link
Author

Glog78 commented Sep 18, 2022

yes it does 👍

@christianparpart
Copy link
Member

Does setting font.render_mode to gray fixes it for you?

Sorry guys, i'm a little late to the party (had a family-weekend outside of cellular network). If setting font.render_mode to gray does fix it for you and you used to use lcd before that reproduces the problem. I wonder why does it cause a problem only for a few glyphs.

Would you mind sending us the generated image file for the texture atlas? You can set a keybind to the action CreateCoreDump, which will write the latest internal state to $HOME/.local/state/contour/dump/latest/ and in there you will have a texture-atlas-rgba.png file, that one you can simply drag'n'drop into the comment field here, I'm highly curious what that atlas looks like (once you see some faulty glyphs on your screen, not before).

Many thanks,
Christian.

@christianparpart christianparpart self-assigned this Sep 18, 2022
@Glog78
Copy link
Author

Glog78 commented Sep 18, 2022

But i need to build debug instead of release ?

@christianparpart
Copy link
Member

But i need to build debug instead of release ?

I am sorry, it is called CreateDebugDump. No you don't. It should always work

@Glog78
Copy link
Author

Glog78 commented Sep 18, 2022

since i edited the older post i will repost.

screenshot
texture-atlas-rgba

@christianparpart
Copy link
Member

It is already uploaded wrong. Many thanks
I will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fonts font rasterization and text shaping API and platform implementations platform: linux topics that directly address Linux platform (any distro)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants