fix: take into account the status line height when rendering sixels. #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test
Utkarsh-khambra
force-pushed
the
fix/1050
branch
from
3d13867 to
176c3f4
Compare
Utkarsh-khambra
changed the title
christianparpart
requested changes
Feb 25, 2023
Utkarsh-khambra
force-pushed
the
fix/1050
branch
from
176c3f4 to
affee03
Compare
github-actions
bot
added
the
VT: rasterizer
Utkarsh-khambra
force-pushed
the
fix/1050
branch
2 times, most recently
from
3850a52 to
ee1d684
Compare
the height of status line as well to draw the whole image.
Utkarsh-khambra
force-pushed
the
fix/1050
branch
from
ee1d684 to
8670045
Compare
christianparpart
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sixel image is being rendered, if status line is visible then total renderable area should not cover the statusline area.
Fixes #1050