Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate category for shader log #1071

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Create separate category for shader log #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c06d485
Separate category for shader log
Yaraslaut Apr 4, 2023
5977c06
Update src/contour/display/ShaderConfig.cpp
Yaraslaut Apr 4, 2023
cdf9e32
Update src/contour/display/ShaderConfig.cpp
Yaraslaut Apr 4, 2023
9daae6b
update metainfo.xml
Yaraslaut Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
<li>Fixes selecting a single character not working easily (#1066).</li>
<li>Fixes cycling between different selection modes (by speed-clicking) not properly working.</li>
<li>Adds `profiles.*.permissions.display_host_writable_statusline` to allow the user to intervene in `DECSSDT` VT sequence to show the host writable statusline even if the indicator statusline is currently active.</li>
<li>Adds `gui.shader` log option for the output of shader configuration procedure.</li>
<li>Extends `ViNormalMode` to toggle between insert and normal mode rather than just entering normal mode.</li>
<li>Modal mode: Adds Return key to also move the cursor down (like vim).</li>
</ul>
Expand Down
4 changes: 3 additions & 1 deletion src/contour/display/ShaderConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ using namespace std::string_literals;
namespace contour::display
{

auto const ShaderLog = logstore::Category("gui.shader", "Logs shader configuration");

namespace
{
template <size_t N>
Expand Down Expand Up @@ -135,7 +137,7 @@ std::unique_ptr<QOpenGLShaderProgram> createShader(ShaderConfig const& _shaderCo
}

if (auto const logString = shader->log().toStdString(); !logString.empty())
errorlog()("Shader log: {}", logString);
ShaderLog()("{}", logString);

Guarantee(shader->isLinked());
return shader;
Expand Down