Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape strings for tcsh #1074

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

cqexbesd
Copy link
Contributor

@cqexbesd cqexbesd commented Apr 5, 2023

Description

The code for tcsh shell integration was missing a round of escapes. This lead to unbalanced quotes and so an error from the shell when it was processed (e.g. when opening a new window).

I also swapped `\033` for `\e` as I think the later will be more readable to people using a C based shell.

Motivation and Context

Why is this change required? What problem does it solve?

Previous code didn't work and printed errors when a new shell started.

How Has This Been Tested?

I just ran it in my shell.

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have read the CONTRIBUTING document in my spoken language, and understand the terms
  • I have updated (or added) the documentation accordingly.
  • I have added tests to cover my changes.
  • I have gone through all the steps, and have thoroughly read the instructions

Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I trust you on this one. :-)

@christianparpart christianparpart merged commit 8aaf906 into contour-terminal:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants