clear search when switch to insert mode

[elmarsan]

Description

There is a weird behavior when entering insert vi mode if you were previously doing searches.
When you search for a term an then switch to insert vi mode, the search term is not deleted. So the search term continues being evaluated if you still using the terminal.

Demo of current behavior

vi-search-mode.webm

Clear search term when switch to insert vi mode

Motivation and Context

Do not execute search term while using insert vi mode

How Has This Been Tested?

• Manually
• Unit tests

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

• I have read the CONTRIBUTING document in my spoken language, and understand the terms
• I have updated (or added) the documentation accordingly.
• I have added tests to cover my changes.
• I have gone through all the steps, and have thoroughly read the instructions

[christianparpart]

I actually liked that behavior but I totally understand why it may be confusing.

Can you add a changeling entry for this into the metainfo.xml?

[Yaraslaut]

I actually liked that behavior but I totally understand why it may be confusing.

Can you add a changeling entry for this into the metainfo.xml?

Maybe we want to make it configurable then? Then you both can have desired behavior, right ?

[christianparpart]

But if it is just me. I do not depend on it

[elmarsan]

I believe the best option is make it configurable. For new users like me is weird, but I can imagine long term users might miss the original behavior.

Shall I make it configurable?

[christianparpart]

Many thanks, @elmarsan.