Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement size indicator on resize #1203

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Sep 15, 2023

Implements #975

EDIT by @christianparpart: This replaces PR #1134.

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Sep 15, 2023
@Yaraslaut Yaraslaut force-pushed the improvement/sizeIndicator branch from 550cbd1 to 9194cd2 Compare September 15, 2023 16:47
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments :)

src/contour/ui.template/Terminal.qml.in Outdated Show resolved Hide resolved
src/contour/ui.template/Terminal.qml.in Outdated Show resolved Hide resolved
src/contour/ui.template/Terminal.qml.in Show resolved Hide resolved
src/contour/ui.template/Terminal.qml.in Outdated Show resolved Hide resolved
src/contour/ui.template/main.qml.in Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 19, 2023
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, @Yaraslaut, but also to @elmarsan for the initial implementation in #1134.

Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christianparpart christianparpart merged commit 7d271cc into master Sep 19, 2023
58 of 60 checks passed
@christianparpart christianparpart deleted the improvement/sizeIndicator branch September 19, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants