Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alt+WheelEvents not captured correctly #1400

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

christianparpart
Copy link
Member

closes #394.

@github-actions github-actions bot added frontend Contour Terminal Emulator (GUI frontend) CMake labels Jan 6, 2024
@christianparpart christianparpart force-pushed the fix/mouse-wheel-alt-modifier branch from 9aee6fa to 6d91e5c Compare January 6, 2024 23:43
@github-actions github-actions bot removed the CMake label Jan 6, 2024
@christianparpart christianparpart force-pushed the fix/mouse-wheel-alt-modifier branch from 6d91e5c to 62460c5 Compare January 7, 2024 00:37
… modifier was pressed at the same time

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart force-pushed the fix/mouse-wheel-alt-modifier branch from 62460c5 to ccfaea7 Compare January 7, 2024 00:42
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, great that we fixed it. One unfortunate thing is that I cannot find documentation for this behavior on the Qt side. What they mention here, https://bugreports.qt.io/browse/QTBUG-30948 not very helpful :(

@christianparpart christianparpart merged commit e86da33 into master Jan 7, 2024
51 of 55 checks passed
@christianparpart christianparpart deleted the fix/mouse-wheel-alt-modifier branch January 7, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alt+WheelEvents not captured correctly
2 participants