Fix thread safety issue on mouse move event handling #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaraslaut
reviewed
Feb 3, 2024
There was a problem hiding this comment.
Unfortunately i can not reproduce behaviour from #1444 so we need to ask @herrhotzenplotz to try this patch
Also, what about mouse press events? they are not protected with lock at the moment, should we guard them as well?
Signed-off-by: Christian Parpart <christian@parpart.family>
christianparpart
force-pushed
the
fix/race-on-mouseMove
branch
from
f1d27b5 to
7de3aee
Compare
|
Good point. I took the time to introduce a |
Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
christianparpart
force-pushed
the
fix/race-on-mouseMove
branch
from
7de3aee to
9aa91e1
Compare
|
Seems to fix #1444 👍 I'll try to switch my default terminal emulator to contour and see if the smoke comes out 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1444.