-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all occurrences of OS/X #1462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick review, what I would NOT do is to edit existing changelog, but add new entry for the change of naming
Many thanks, @fingolfin. I think I'm used to name it like that from the time it was named like that (just without the slash): Not sure were the slash is coming from, in my memories :) |
The Macintosh operating system underwent many name changes over the years, from being nameless to "System" to "Mac OS" to "OS X" to "macOS". But at no point in time was it ever called "OS/X" :-)
But why not? Would you not fix typos in them either?
OK, if you want a changelog entry for a typo fix, I am happy to add it -- except I have no idea how. I am guessing |
Lines 107 to 113 in cdb2e16
Hey. This is going to be the changelog for the next release. You can simply add yourself at the end of it. Changelogs can of course be typo-fixed, but I remember from other big open source projects that change logs are only about to be changed for present/future entries, not touching past entries. So I think that's a philosophy thing :) |
Hey @fingolfin. Can I help you with anything? |
I don't time to work on this outside of weekends. Anyway, this is a trivial search&replace change. Feel free to finish the PR in whichever way you want it, or to close it / do your own version of it. |
ca136dd
into
contour-terminal:master
I've added the changelog entry after the merge. Many thanks @fingolfin for your contribution and support. :-) |
The Macintosh operating system underwent many name changes over the years,
from being nameless to "System" to "Mac OS" to "OS X" to "macOS".
But at no point in time was it ever called "OS/X" :-)