Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement vi mode jumps #1646

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Implement vi mode jumps #1646

merged 1 commit into from
Nov 12, 2024

Conversation

Yaraslaut
Copy link
Member

Closes #1101

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Oct 26, 2024
@Yaraslaut Yaraslaut marked this pull request as draft October 26, 2024 18:59
@Yaraslaut Yaraslaut marked this pull request as ready for review October 28, 2024 12:56
@Yaraslaut Yaraslaut force-pushed the features/vi_jumps branch 5 times, most recently from 507bcc9 to 878b77a Compare October 28, 2024 13:49
@Yaraslaut Yaraslaut force-pushed the features/vi_jumps branch 3 times, most recently from 89195dd to fb7a3ac Compare November 5, 2024 10:27
christianparpart
christianparpart reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @Yaraslaut. I've tested it locally, and it's amazing. I only left very few comments though :)

src/vtbackend/ViInputHandler.h Outdated Show resolved Hide resolved
metainfo.xml Outdated Show resolved Hide resolved
src/vtbackend/JumpHistory.cpp Show resolved Hide resolved
src/vtbackend/JumpHistory.h Show resolved Hide resolved
src/vtbackend/JumpHistory.h Outdated Show resolved Hide resolved
src/vtbackend/JumpHistory.h Outdated Show resolved Hide resolved
src/vtbackend/ViCommands.cpp Outdated Show resolved Hide resolved
@Yaraslaut Yaraslaut merged commit cd7d26e into master Nov 12, 2024
32 checks passed
@Yaraslaut Yaraslaut deleted the features/vi_jumps branch November 12, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vi-like normal mode: support Jumps
2 participants
@Yaraslaut @christianparpart