Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terminal_renderer] Fixes rendering of U+E0B2  in pixel-perfect box drawing mode (#707). #709

Merged
merged 1 commit into from
Jun 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Fixes VT sequence for setting indexed color from palette.
- Fixes some config false positives error messages.
- Fixes command line arguments parser handling of `--` for switching to verbatim mode (#670).
- Fixes rendering of U+E0B2  in pixel-perfect box drawing mode (#707).
- Changes `XTSMGRAPHICS` to match implementation of xterm *exactly* when querying sixel image limits, to be capped at terminal viewport dimensions (#656).
- Win32: Attaches to parent console if present, so typing `contour help` in a terminal actually shows something.
- Implements UTF-8 encoded mouse transport (`CSI ? 1005 h`)
Expand Down
5 changes: 4 additions & 1 deletion src/terminal_renderer/BoxDrawingRenderer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,10 @@ namespace detail
template <Dir Direction, int DivisorX>
auto getTriangleProps(ImageSize size)
{
auto const c = Point { unbox<int>(size.width) / DivisorX, unbox<int>(size.height) / 2 };
auto const c =
Point { Direction == Dir::Left ? unbox<int>(size.width) / DivisorX
: unbox<int>(size.width) - unbox<int>(size.width) / DivisorX,
unbox<int>(size.height) / 2 };
auto const w = unbox<int>(size.width) - 1;
auto const h = unbox<int>(size.height) - 1;

Expand Down