Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the sixel aspect ratio. #827

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Fixes the sixel aspect ratio. #827

merged 1 commit into from
Sep 25, 2022
+72 −43

Conversation

Utkarsh-khambra
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Sep 23, 2022
christianparpart
christianparpart reviewed Sep 24, 2022
View reviewed changes
src/terminal/SixelParser.cpp Outdated Show resolved Hide resolved
src/terminal/SixelParser.cpp Outdated Show resolved Hide resolved
src/terminal/SixelParser.cpp Outdated Show resolved Hide resolved
src/terminal/SixelParser.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added the test Unit tests label Sep 24, 2022
@Utkarsh-khambra Utkarsh-khambra force-pushed the fix/sixel_aspect_ratio branch 4 times, most recently from cb66b00 to 005e14d Compare September 24, 2022 20:45
@Utkarsh-khambra
Copy link
Collaborator Author

Now it passes this test
Screenshot from 2022-09-25 02-31-37

and this test
Screenshot from 2022-09-25 02-31-52

but don't know why we display transparent colors?

@Utkarsh-khambra Utkarsh-khambra marked this pull request as ready for review September 24, 2022 21:08
@christianparpart christianparpart mentioned this pull request Sep 25, 2022
Closed
@christianparpart
Copy link
Member

but don't know why we display transparent colors?

Fixed on master, as per #833.

christianparpart
christianparpart approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianparpart christianparpart merged commit 850b0f2 into master Sep 25, 2022
@christianparpart christianparpart deleted the fix/sixel_aspect_ratio branch September 25, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j4james j4james j4james left review comments

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Utkarsh-khambra @christianparpart @j4james