fix: set content-length header on sendResponseResult (#145)

* Set content-length on sendResponseResult * Use Buffer.byteLength instead of creating new buffer * Added changeset * Added unit test checks for content-length header
contra · Nov 25, 2021 · d6071a1 · d6071a1
1 parent e86800f
commit d6071a1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/weak-kids-leave.md b/.changeset/weak-kids-leave.md
@@ -0,0 +1,5 @@
+---
+"graphql-helix": patch
+---
+
+Set content-length header on sendResponseResult
diff --git a/packages/core/lib/send-result/node-http.ts b/packages/core/lib/send-result/node-http.ts
@@ -15,10 +15,12 @@ export async function sendResponseResult(
   for (const { name, value } of responseResult.headers) {
     rawResponse.setHeader(name, value);
   }
+  const data = JSON.stringify(transformResult(responseResult.payload))
   rawResponse.writeHead(responseResult.status, {
     "content-type": "application/json",
+    "content-length": Buffer.byteLength(data, "utf8")
   });
-  rawResponse.end(JSON.stringify(transformResult(responseResult.payload)));
+  rawResponse.end(data);
 }
 
 export async function sendMultipartResponseResult(

diff --git a/packages/core/test/integration.test.ts b/packages/core/test/integration.test.ts
@@ -86,6 +86,7 @@ implementations.forEach((implementation) => {
       test("POST basic query", async () => {
         const {
           body: { data, errors },
+          headers,
         } = await post({
           path: "/graphql",
           port,
@@ -97,6 +98,7 @@ implementations.forEach((implementation) => {
         });
         expect(errors).toBeUndefined();
         expect(data?.echo).toBeDefined();
+        expect(headers['content-length']).toBeDefined();
       });
 
       test("POST query with variables", async () => {
@@ -249,6 +251,7 @@ implementations.forEach((implementation) => {
       test("GET basic query", async () => {
         const {
           body: { data, errors },
+          headers,
         } = await get({
           path: "/graphql",
           port,
@@ -260,6 +263,7 @@ implementations.forEach((implementation) => {
         });
         expect(errors).toBeUndefined();
         expect(data?.echo).toBeDefined();
+        expect(headers['content-length']).toBeDefined();
       });
 
       test("GET query with variables", async () => {