Rework Faktory's error handling to include more context

[mperham]

Today Faktory gets errors and naively prints them out, without any sort of context or backtrace. Seeing something like "Socket closed: EOF" gives the user exactly zero information with which to debug.

• Research how Go errors can be improved.
• Decide on highest "bang for the buck" improvement we can roll out to the codebase without customizing every single return err block.
• Roll out to Faktory, Pro and Enterprise.

[gearnode]

In Go, to have context you have to wrap errors with the %w (since Go 1.13), you have no other real possibility... Go is not customizable as Ruby can be. You can also, create custom Go error struct to add more context on some errors.

E.g.

file, err := OpenFile()
if err != nil {
  return fmt.Errorf("cannot open file: %w", err)
}

I can open pull request with the error wrapping if it can helps.

[mperham]

@gearnode I was thinking we could integrate pkg/errors but I don't know how much value it provides vs error handling in Go 1.13+.

[gearnode]

Since Go 1.13 the pkg/errors not add a lot of value because Go support error wrapping natively. I not use pkg/errors anymore in my project, since Go add wrapping error supports.

[gearnode]

@mperham I send you a first draft git patch if you want some help to wrap errors :)

[mperham]

I didn't see any patch?

…

On Sat, May 2, 2020 at 5:16 PM Bryan FRIMIN ***@***.***> wrote: @mperham <https://github.com/mperham> I send you a first draft git patch if you want some help to wrap errors :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#296 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAWX5K4VJUXRUADGM7XEDRPSZXFANCNFSM4MMOKSLA> .

[gearnode]

My bad I forgot to open the patch :(