Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Translator to SymfonyValidator #211

Merged
merged 1 commit into from
May 24, 2024

Conversation

martenb
Copy link
Contributor

@martenb martenb commented May 21, 2024

Tested on our internal project

Setting the translator
image

Setting the apitte
image

Translated errors
image

@martenb martenb force-pushed the feat/translator branch from edea9a4 to e289f49 Compare May 22, 2024 08:00
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.78%. Comparing base (e78b02d) to head (7591dde).
Report is 9 commits behind head on master.

Files Patch % Lines
src/Core/Mapping/Validator/SymfonyValidator.php 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   90.62%   89.78%   -0.84%     
==========================================
  Files         105      105              
  Lines        2410     2261     -149     
==========================================
- Hits         2184     2030     -154     
- Misses        226      231       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martenb martenb force-pushed the feat/translator branch from e289f49 to 7591dde Compare May 22, 2024 20:37
@f3l1x f3l1x merged commit f6f7d56 into contributte:master May 24, 2024
8 of 10 checks passed
@martenb
Copy link
Contributor Author

martenb commented Jul 31, 2024

can i ask when it will be released? @f3l1x

@f3l1x
Copy link
Member

f3l1x commented Aug 1, 2024

Releaaaaaased. :-)

https://github.com/contributte/apitte/releases/tag/v0.12.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants