Skip to content

Add support for parameters (custom extension) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Add support for parameters (custom extension) #23

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79b29ae
Add support for parameters (custom extension)
universe-42 Mar 8, 2020
34dda53
Add callback onCreateConfigurator
universe-42 Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Module/NetteDIModule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ class NetteDIModule extends Module

/** @var callable[] function(Container $container): void; */
public $onCreateContainer = [];

/** @var array */
Copy link
Member

@f3l1x f3l1x Mar 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** @var array */
/** @var mixed[] */

public $parameters = [];

/** @var mixed[] */
protected $config = [
Expand Down Expand Up @@ -129,11 +132,13 @@ private function createContainer(): void
$configurator->enableDebugger($logDir);
}

$configurator->addParameters([
$parameters = array_merge($this->parameters, [
'appDir' => $this->path . ($this->config['appDir'] !== null ? '/' . $this->config['appDir'] : ''),
'wwwDir' => $this->path . ($this->config['wwwDir'] !== null ? '/' . $this->config['wwwDir'] : ''),
]);

$configurator->addParameters($parameters);
Copy link
Contributor

@mabar mabar Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still very limiting. Please split createContainer into createConfigurator and createContainer. Should work like that: create and configure configurator, run onCreateConfigurator events, create container, run onCreateContainer events


$this->clearTempDir();
$tempDir = $this->getTempDir();
$configurator->setTempDirectory($tempDir);
Expand Down