Open visibility for better inheritance usage. #1073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jannovy Why don't you use method |
|
@radimvaculik The goal is to use a custom implementation of the DoctrineDataSource class. So I have to create child class of DataModel to replace \Ublaboo\DataGrid\DataSource\DoctrineDataSource by my own \App\DataGrid\DataSource\DoctrineDataSource Or is there some other shortcut ? |
|
@jannovy Ping. |
|
@radimvaculik Yes, this is solution for me. |
|
@jannovy Can we close this issue? |
|
@radimvaculik Yes, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to customize DoctrineDataSource class to improve Doctrine performance. This is the most simple way how to embed my own DoctrineDataSource to DataModel and DataGrid.