Request values of inline add/edit containers only when this part of form is submitted #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add some tests? |
|
So I rewrote this fix a bit, added test and rebased branch. I'm not sure if I did it right. Should I create new pull request or something? |
|
It's good, only one thing, can you please target this MR to master branch and not 6.x? |
|
Ok, I've changed target branch to master and there are some conflicts. |
vvoody-
force-pushed
the
inline-form-mapping
branch
from
226bcb6 to
c494ece
Compare
|
Done |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline add/edit form container can be mapped to object with required properties, so creation of this value object will fail when form controls are set as required but their validation is skipped by validation scope for example when grid filter is submitted.