Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctrine filters #72

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Doctrine filters #72

merged 3 commits into from
Mar 26, 2020

Conversation

patrickkusebauch
Copy link
Contributor

@patrickkusebauch patrickkusebauch commented Mar 23, 2020 •
edited
Loading

Resolves: #71
No BC break

Ability to add filter definitions to NEON config.

Not sure about tests and documentation. I was unable to find any pattern as to whether I should edit those too or not.

@f3l1x
Copy link
Member

f3l1x commented Mar 23, 2020

image

@f3l1x
Copy link
Member

f3l1x commented Mar 23, 2020

We definitely need some tests. It should be easy to write them.

@patrickkusebauch
Copy link
Contributor Author

@f3l1x added tests and documentation as per request.

@f3l1x f3l1x merged commit 9fe0db4 into contributte:master Mar 26, 2020
@f3l1x
Copy link
Member

f3l1x commented Mar 26, 2020

Thanks

@patrickkusebauch patrickkusebauch deleted the filters branch March 27, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doctrine Filters - regitration in NEON config
2 participants
@patrickkusebauch @f3l1x