Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix failing GitHub Actions workflows #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Roman3349
Copy link
Member

No description provided.

@Roman3349 Roman3349 changed the title Fix failing GitHub Actions workflows Draft: Fix failing GitHub Actions workflows Mar 11, 2025
Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
@Roman3349
Copy link
Member Author

@f3l1x Tests with the lowest versions of dependencies (https://github.com/contributte/flysystem/actions/runs/13796949549/job/38590746281?pr=17) are failing because Nette\DI 3.0 is used which uses deprecated ReflectionParameter::isArray(). Should I add a dependency on "nette/di":"^3.1" to composer.json or will there be a new version of "contributte/di" that depends on "nette/di":"^3.1"?

@f3l1x
Copy link
Member

f3l1x commented Mar 11, 2025

I will drop dependency on contributte/di, whole DefinitionHelper in CompilerExtension was wrong way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants