fix(cli): remove default value from edit option #2065

move pseudo default to "main" function
conventional-changelog · Sep 5, 2020 · 3d4116d · 3d4116d
1 parent 3fe8ae3
commit 3d4116d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/@commitlint/cli/src/cli.test.ts b/@commitlint/cli/src/cli.test.ts
@@ -442,8 +442,7 @@ test('should print help', async () => {
 		  --cwd, -d            directory to execute in
 		                                         [string] [default: (Working Directory)]
 		  --edit, -e           read last commit message from the specified file or
-		                       fallbacks to ./.git/COMMIT_EDITMSG
-		                                                       [string] [default: false]
+		                       fallbacks to ./.git/COMMIT_EDITMSG               [string]
 		  --env, -E            check message in the file at path given by environment
 		                       variable value                                   [string]
 		  --extends, -x        array of shareable configurations to extend       [array]

diff --git a/@commitlint/cli/src/cli.ts b/@commitlint/cli/src/cli.ts
@@ -42,7 +42,6 @@ const cli = yargs
 		},
 		edit: {
 			alias: 'e',
-			default: false,
 			description:
 				'read last commit message from the specified file or fallbacks to ./.git/COMMIT_EDITMSG',
 			type: 'string',
@@ -112,7 +111,7 @@ const cli = yargs
 	)
 	.strict();
 
-main(cli.argv).catch((err) => {
+main({edit: false, ...cli.argv}).catch((err) => {
 	setTimeout(() => {
 		if (err.type === pkg.name) {
 			process.exit(1);