Skip to content

type-enum fills in with angular values even when a lintrc file is included #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremypress opened this issue Mar 30, 2017 · 2 comments
Labels

Comments

@jeremypress
Copy link

jeremypress commented Mar 30, 2017

Hi, I have a lintrc file that includes 7 values for type-enum. When I write a commit that fails that check, the list of possible type-enums includes 3 values from the angular config: 'revert', 'style' and 'test'.

my lintrc rule looks like this:

"type-enum": [ 2, "always", [ "Fix", "New", "Breaking", "Docs", "Build", "Upgrade", "Chore", "Update" ] ],

and I'm using husky in my package.json with "commitmsg": "conventional-changelog-lint -e",

this is my terminal output when I fail that check:
type must be one of ["Fix", "New", "Breaking", "Docs", "Build", "Upgrade", "Chore", "Update", "revert", "style", "test"] [type-enum]

Thanks for making this library!

@marionebl
Copy link
Contributor

Thanks for reporting - I'll check on this over the next days!

@marionebl marionebl added the bug label Mar 31, 2017
@marionebl
Copy link
Contributor

Fixed by #30 and released:

❯ npm show conventional-changelog-lint .version
1.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants