Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camel-case is confused with sentence-case / start-case #3501

Open
1 of 4 tasks
sschuberth opened this issue Jan 13, 2023 · 0 comments
Open
1 of 4 tasks

Camel-case is confused with sentence-case / start-case #3501

sschuberth opened this issue Jan 13, 2023 · 0 comments
Labels
bug help wanted

Comments

@sschuberth
Copy link

Expected Behavior

If only sentence-case and start-case are denied from scopes, I'd expect camel-case to work.

Current Behavior

With

  scope-case:
    - 2
    - never
    - - sentence-case
      - start-case

I get

⧗   input: fix(ClearlyDefined): Make `Described` use `CurationFacets`

These are glob lists, not facet objects.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
✖   scope must not be sentence-case, start-case [scope-case]

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

When checking for sentence-case / start-case, ensure that there is more than a single word.

Steps to Reproduce

See https://github.com/oss-review-toolkit/ort/actions/runs/3909253534/jobs/6680143679#step:4:17

Context

No response

commitlint --version

17.4.2

git --version

2.39.0

node --version

16.14.2
@sschuberth sschuberth added the bug label Jan 13, 2023
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Jan 13, 2023
@sschuberth
fix(commitlint): Invert the logic to define scope-case
bd5f5c4 
This works around [1].

[1]: conventional-changelog/commitlint#3501

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Jan 13, 2023
@sschuberth
fix(commitlint): Invert the logic to define scope-case
bb2e748 
This works around [1].

[1]: conventional-changelog/commitlint#3501

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth sschuberth mentioned this issue Mar 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @escapedcat